Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v16: Expose the unstable metadata v16 #5732

Merged
merged 87 commits into from
Nov 27, 2024

Conversation

lexnv
Copy link
Contributor

@lexnv lexnv commented Sep 16, 2024

This PR exposes the unstable metadata V16. The metadata is exposed under the unstable u32::MAX number.

Developers can start experimenting with the new features of the metadata v16. Please note that this metadata is under development and expect breaking changes until stabilization.

The ExtrinsicMetadata trait receives a breaking change. Its associated type VERSION is rename to VERSIONS and now supports a constant static list of metadata versions.
The versions implemented for UncheckedExtrinsic are v4 (legacy version) and v5 (new version).

For metadata collection, it is assumed that all TransactionExtensions are under version 0.

Builds on top of: #5274

Closes: #5980
Closes: #5347
Closes: #5285

cc @paritytech/subxt-team

lexnv added 30 commits August 7, 2024 18:05
Signed-off-by: Alexandru Vasile <[email protected]>
Signed-off-by: Alexandru Vasile <[email protected]>
Signed-off-by: Alexandru Vasile <[email protected]>
Signed-off-by: Alexandru Vasile <[email protected]>
Signed-off-by: Alexandru Vasile <[email protected]>
Signed-off-by: Alexandru Vasile <[email protected]>
Signed-off-by: Alexandru Vasile <[email protected]>
Signed-off-by: Alexandru Vasile <[email protected]>
@lexnv lexnv enabled auto-merge November 20, 2024 13:28
@lexnv lexnv requested a review from Morganamilo November 20, 2024 13:32
@lexnv
Copy link
Contributor Author

lexnv commented Nov 20, 2024

@Morganamilo could you please take a look over .github/workflows/check-semver.yml changes? 🙏

I would like to merge this and backport it on the latest release, I think an in-depth fix for semver will follow in: #6549

…associated-types-enable-unstable

Signed-off-by: Alexandru Vasile <[email protected]>
@lexnv lexnv removed request for a team November 26, 2024 10:55
@lexnv lexnv disabled auto-merge November 26, 2024 11:00
Copy link
Contributor

@pgherveou pgherveou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for pallet-revive ownership

@lexnv lexnv added this pull request to the merge queue Nov 27, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 27, 2024
@lexnv lexnv added this pull request to the merge queue Nov 27, 2024
Merged via the queue into master with commit 5b1b34d Nov 27, 2024
195 of 198 checks passed
@lexnv lexnv deleted the lexnv/metadata-v16-associated-types-enable-unstable branch November 27, 2024 13:01
EgorPopelyaev added a commit that referenced this pull request Nov 27, 2024
This PR is a backport for:
- #5732

cc @paritytech/subxt-team

---------

Signed-off-by: Alexandru Vasile <[email protected]>
Co-authored-by: Egor_P <[email protected]>
Krayt78 pushed a commit to Krayt78/polkadot-sdk that referenced this pull request Dec 18, 2024
This PR exposes the *unstable* metadata V16. The metadata is exposed
under the unstable u32::MAX number.

Developers can start experimenting with the new features of the metadata
v16. *Please note that this metadata is under development and expect
breaking changes until stabilization.*

The `ExtrinsicMetadata` trait receives a breaking change. Its associated
type `VERSION` is rename to `VERSIONS` and now supports a constant
static list of metadata versions.
The versions implemented for `UncheckedExtrinsic` are v4 (legacy
version) and v5 (new version).

For metadata collection, it is assumed that all `TransactionExtensions`
are under version 0.

Builds on top of: paritytech#5274

Closes: paritytech#5980
Closes: paritytech#5347
Closes: paritytech#5285

cc @paritytech/subxt-team

---------

Signed-off-by: Alexandru Vasile <[email protected]>
Co-authored-by: Niklas Adolfsson <[email protected]>
Co-authored-by: Bastian Köcher <[email protected]>
Co-authored-by: James Wilson <[email protected]>
Co-authored-by: GitHub Action <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I5-enhancement An additional feature request. T1-FRAME This PR/Issue is related to core FRAME, the framework.
Projects
Status: Done
9 participants